Upgraded to Rubocop 0.84.0.

ruby-grape · May 26, 2020 · bed22d5 · bed22d5
1 parent 567755c
commit bed22d5
Show file tree

Hide file tree

Showing 12 changed files with 13 additions and 12 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-05-18 14:31:59 +0200 using RuboCop version 0.83.0.
+# on 2020-05-26 08:28:37 -0400 using RuboCop version 0.84.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -223,7 +223,7 @@ Style/WordArray:
     - 'spec/grape/validations/validators/except_values_spec.rb'
     - 'spec/grape/validations/validators/values_spec.rb'
 
-# Offense count: 1339
+# Offense count: 125
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 #### Features
 
+* [#2060](https://github.com/ruby-grape/grape/pull/2060): Upgraded Rubocop to 0.84.0 - [@dblock](https://github.com/dblock).
 * Your contribution here.
 
 #### Fixes

diff --git a/Gemfile b/Gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/multi_json.gemfile b/gemfiles/multi_json.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/multi_xml.gemfile b/gemfiles/multi_xml.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/rack1.gemfile b/gemfiles/rack1.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/rack2.gemfile b/gemfiles/rack2.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/rack_edge.gemfile b/gemfiles/rack_edge.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/rails_5.gemfile b/gemfiles/rails_5.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/rails_6.gemfile b/gemfiles/rails_6.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/gemfiles/rails_edge.gemfile b/gemfiles/rails_edge.gemfile
@@ -10,7 +10,7 @@ group :development, :test do
   gem 'bundler'
   gem 'hashie'
   gem 'rake'
-  gem 'rubocop', '0.80.1'
+  gem 'rubocop', '0.84.0'
   gem 'rubocop-performance', require: false
 end
 

diff --git a/spec/grape/middleware/auth/strategies_spec.rb b/spec/grape/middleware/auth/strategies_spec.rb
@@ -36,7 +36,7 @@ def app
     RSpec::Matchers.define :be_challenge do
       match do |actual_response|
         actual_response.status == 401 &&
-          actual_response['WWW-Authenticate'] =~ /^Digest / &&
+          actual_response['WWW-Authenticate'].start_with?('Digest ') &&
           actual_response.body.empty?
       end
     end