Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPTIONS method for namespaced GET does not call inner before filter #1428

Closed
jlfaber opened this issue Jun 15, 2016 · 2 comments
Closed

OPTIONS method for namespaced GET does not call inner before filter #1428

jlfaber opened this issue Jun 15, 2016 · 2 comments
Assignees
@namusyaka
Labels
confirmed bug

Comments

@jlfaber
Copy link
Contributor

jlfaber commented Jun 15, 2016 •
edited
Loading

When I use a namespace to define a GET method, and I add a before filter within the namespace block, that filter is called when GET executes, but is not called when OPTIONS executes. This differs from the behavior when the GET and before filter are not within a namespace. In that case, the before filter is called both for GET and OPTIONS.

I'll add a PR with a failing test spec to demonstrate the issue.
jlfaber pushed a commit to jlfaber/grape that referenced this issue Jun 15, 2016
Ensure that OPTIONS calls inner before block
9a4e9eb 
This demonstrates issue ruby-grape#1428.
@jlfaber jlfaber mentioned this issue Jun 15, 2016
Closed
@dblock
Copy link
Member

dblock commented Jun 15, 2016

Yep, looks like a bug.

jlfaber pushed a commit to jlfaber/grape that referenced this issue Jul 20, 2016
Ensure that OPTIONS calls inner before block
1dd3f7b 
This demonstrates issue ruby-grape#1428.
@namusyaka namusyaka self-assigned this Sep 7, 2016
@namusyaka
Copy link
Contributor

I'm going to fix it in a few days. Thanks for the report.

namusyaka added a commit that referenced this issue Sep 11, 2016
@namusyaka
Ensure calling before filters when receiving OPTIONS request
1319e97 
Fixes #1428
namusyaka pushed a commit to namusyaka/grape that referenced this issue Sep 11, 2016
@namusyaka
Ensure that OPTIONS calls inner before block
8f11257 
This demonstrates issue ruby-grape#1428.
namusyaka added a commit to namusyaka/grape that referenced this issue Sep 11, 2016
@namusyaka
Ensure calling before filters when receiving OPTIONS request
0cedbfe 
  Fixes ruby-grape#1428
@namusyaka namusyaka mentioned this issue Sep 11, 2016
Merged
@dblock dblock closed this as completed in 3e9ed2f Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namusyaka namusyaka

Labels
confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@namusyaka @jlfaber @dblock