Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rspec to >= 3.9.0 #2247

Closed
dblock opened this issue Feb 27, 2022 · 0 comments · Fixed by #2248
Closed

Upgrade rspec to >= 3.9.0 #2247

dblock opened this issue Feb 27, 2022 · 0 comments · Fixed by #2248

Comments

@dblock
Copy link
Member

dblock commented Feb 27, 2022

Versions of rspec >= 3.9.0 fail tests unexpectedly, e.g. https://github.com/ruby-grape/grape/runs/5347064188?check_suite_focus=true


  1) Grape::DSL::Routing.version sets a version for route
     Failure/Error: namespace_inheritable(:version_options, options)

       #<#<Class:0x000055f796d81f10> (class)> received :namespace_inheritable with unexpected arguments
         expected: (:version_options, {:using=>:path})
              got: (:version_options, {:using=>:path})
     # ./lib/grape/dsl/routing.rb:48:in `version'
     # ./spec/grape/dsl/routing_spec.rb:23:in `block (3 levels) in <module:DSL>'

This is obviously wrong since the parameters received are identical to the expectation.

Possibly a bug in rspec-expectations.

In #2246 I locked the version of rspec to 3.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant