Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete dev guide. #1357

Closed
wants to merge 1 commit into from
Closed

Removed obsolete dev guide. #1357

wants to merge 1 commit into from

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Feb 27, 2022

I came here to try to repro ruby-grape/grape#2247 and bundle install failed with the following.

osx ~/source/rspec-expectations/rspec (main)$ bundle
Fetching https://github.com/rspec/rspec-core.git
Fetching https://github.com/rspec/rspec-mocks.git
Fetching https://github.com/rspec/rspec-support.git
Fetching gem metadata from https://rubygems.org/.........
Could not find gem 'rspec' in source at `/Users/dblock/source/rspec-expectations/rspec`.
The source does not contain any versions of 'rspec'

The instructions in DEV-README.md are incorrect and the file has typos (environment). Removed it in favor of the generated DEVELOPMENT.md.

Fixed README on how to contribute to rspec-expectations with export USE_GIT_REPOS=1, without rspec-dev.

Removed obsolete DEV-README.md in favor of the generated DEVELOPMENT.md.
Clarify how to contribute to rspec-expectations without rspec-dev.
@pirj
Copy link
Member

pirj commented Feb 27, 2022

The old way still works for me:

$ git clone https://github.com/rspec/rspec-expectations.git
$ cd rspec-expectations
$ bundle
Fetching https://github.com/rspec/rspec-support.git
Fetching https://github.com/rspec/rspec-mocks.git
Fetching https://github.com/rspec/rspec-core.git
Fetching https://github.com/rspec/rspec.git
Fetching gem metadata from https://rubygems.org/.........
...

USE_GIT_REPOS is not exported.

I suspect this check is failing for you.

You have the repo checked out in ~/source/rspec-expectations/rspec, and that confuses this condition. Check it out to ~/source/rspec-expectations, and it will work fine.

@pirj pirj closed this Feb 27, 2022
@dblock
Copy link
Contributor Author

dblock commented Feb 27, 2022

Thanks. I PRed typos fixes in #1360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants