Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested APIs not calling before/after filters properly #383

Closed
seanmoon opened this issue Apr 15, 2013 · 1 comment · Fixed by #416
Closed

Nested APIs not calling before/after filters properly #383

seanmoon opened this issue Apr 15, 2013 · 1 comment · Fixed by #416

Comments

@seanmoon
Copy link
Contributor

Hi there,

Thanks last time around with the versioning header issues. Ran into another problem today.

Here's a commit with a failing test: seanmoon@bc3b048

May be related to #369 ?

Looks like if you go one level deep in the mounting chain, everything is okay with regard to before filters (which is confirmed by the current specs), but once you go to the second level it starts failing. This spec may need some reformatting to follow the style of the other before filter tests, but the spec I wrote parallels the code in my application that is not working correctly :)

I'm going to solve my immediate issue by duplicating the before filter between my V1 and V2 API classes, and if no one has figured this out by then I'll try to take a crack at it.

@dblock
Copy link
Member

dblock commented Apr 15, 2013

This looks like a bug, thank you. Appreciate a fix.

seanmoon added a commit to seanmoon/grape that referenced this issue May 29, 2013
seanmoon added a commit to seanmoon/grape that referenced this issue May 29, 2013
seanmoon added a commit to seanmoon/grape that referenced this issue May 30, 2013
@dblock dblock closed this as completed in 78ee4fe May 30, 2013
dblock added a commit that referenced this issue May 30, 2013
Fix #383: Inherit settings correctly when performing nested mounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants