Helper functions not available in rescue_from

[skwp]

Hi, we are trapping errors in rescue_from but unable to log them because the logger variable appears out of scope. Any ideas on how to access it? Thanks.

[skwp]

I was able to get around this by defining a constant. It's a bit ugly but it works...something like this:

module API
   LOGGER = Logger.new(...)
   logger LOGGER

   rescue_from :all do |e|
     LOGGER.error e
   end
end

[ismaelga]

I think you should leave it open. I think logger should be available there without hacks

[aac]

none of the helpers are available in rescue_from either, no?

On Wed, Jul 17, 2013 at 8:45 AM, Ismael Abreu notifications@github.comwrote:

I think you should leave it open. I think logger should be available
there without hacks

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/438#issuecomment-21110122
.

[skwp]

correct, no helpers are available there. I think it's a bit strange.

[ecielam]

+1 Fixing this would be GREAT.

[col]

+1

[sheerun]

+1, the error! is not available, so I can't pass error code

[kamui]

+1 I just ran into this issue as well, trying to access error! and a helper wrapping error! from a rescue_from block.

[schultyy]

+1
Also ran into this error today.

[cmaitchison]

You can access helpers, etc from a rescue_from like this:

rescue_from StandardError do |e|
  env['api.endpoint'].helper_method
end

[jmondo]

@cmaitchison that tip was super helpful thanks!

[jeremyhaile]

Thanks for the workaround. This is a huge pain. Please fix!

[thimios]

Would be great to fix this, also the workaround does not work for me:

class App < Grape::API
  rescue_from ActiveRecord::RecordNotFound do |e|
      env['api.endpoint'].error!( e.message, 404 )
  end
end

Gives:

ArgumentError: uncaught throw :error

any ideas?

thanks!

[aserafin]

I'm using it like this https://github.com/aserafin/grape_logging#logging-exceptions. You can also checkout the gem itself - it provides you with basic similar to Rails logging features.

[jamesmoriarty]

@cmaitchison life saver.

[flocsy]

+1, logger is essential in the whole code, especially in rescue_from. It's a pity it wasn't solved yet after more than 2 years :(

[dblock]

@flocsy Make a PR?

[zuk]

Just for the record, error! is available in rescue_from blocks since 0.12.0. See #974

Other/custom helpers however still aren't.

[dblock]

This was fixed on HEAD, thanks @namusyaka.