-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requests with big payloads are extremely slow due to bug in Hashie::Mash #494
Comments
What's the stack for where one hits this in Grape? Basically, how does one know whether this affects them badly or not? |
I'll post some cases later, but I found that swapping in the patched |
Fyi, I have a branch with the fix and tests, https://github.com/dblock/hashie/tree/convert-value-performance-fix. |
…requests carrying a large payload, #494.
Closed via a77ac5b. |
Requests with big payloads (in our case a large JSON object) are extremely slow. This is due to a bug in
Hashie::Mash
. See here: hashie/hashie#107Once that pull request is pulled in, I'd recommend switching Grape's minimum requirement for
hashie
to>= 2.0.6
(assuming this gets released as 2.0.6).In the meantime adding the git requirement to our Gemfile seems to have fixed the problem in grape:
gem 'hashie', :git => 'https://github.com/connectedbits/hashie.git'
The text was updated successfully, but these errors were encountered: