Use proper .format suffix if you have one path, issue 965 #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,7 @@ | |||
| * [#988](https://github.com/intridea/grape/pull/988): Fixed duplicate identical endpoints - [@u2](https://github.com/u2). | |||
| * [#936](https://github.com/intridea/grape/pull/936): Fixed default params processing for optional groups - [@dm1try](https://github.com/dm1try). | |||
| * [#942](https://github.com/intridea/grape/pull/942): Fixed forced presence for optional params when based on a reused entity that was also required in another context - [@croeck](https://github.com/croeck). | |||
| * [#1001](https://github.com/intridea/grape/pull/1001/files): Fixed calling endpoint with specified format with format in its path. | |||
There was a problem hiding this comment.
Needs - [@hodak](...) like all the lines above, please.
|
As we're undoing behavior introduced in a prior version this also needs an UPGRADING note, please. |
|
Thanks for doing this @hodak, needs some minor updates, see above. Please squash your commits too. |
Both should work: format :json * /users * /users.json
|
Done & done, thanks! ;) |
|
Merging. I will add some notes on the regression. |
dblock
added a commit
that referenced
this pull request
Apr 27, 2015
…e-965 Use proper .format suffix if you have one path, issue 965
dblock
added a commit
that referenced
this pull request
Apr 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
so I had an issue #965 After investigating it all, it seemed like it was very unexpected behavior:
introduced with PR #809
It turned out it was strictly related to the issue I was having. I think it's logical to allow calling endpoint with specified format.
I saw @dblock comments about changing this (1, 2) so I decided to do this.
I've also added specs with the specific issue I was having with deeply nesting concerns.
Best