Adding headers to validation errors #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,9 @@ Next Release | |||
|
|
|||
| #### Features | |||
|
|
|||
| * [#1062](https://github.com/intridea/grape/issues/1062): Added headers | |||
There was a problem hiding this comment.
Put this on 1 line and match the syntax from below (no period before -, quote ValidationErrors).
Maybe we can phrase this better, "Fix: validation errors will include headers set by header"?
|
I think this makes sense, and the fact that headers aren't included is a bug, can you amend the CHANGELOG per above please? |
|
Sorry I don't know how the changelog was multiple lines. Let me know if it needs any more changes. |
|
I just want these squashed ;) Thanks! |
yairgo
force-pushed
the
pass_headers_to_validation_errors
branch
from
35dde86
to
f95445a
Compare
|
Squashed |
…onse. Fixing changlog message.
dblock
added a commit
that referenced
this pull request
Jul 13, 2015
Adding headers to validation errors
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding headers to validation errors instance to be used in error response.
#1062