Allow parameters with more than one type. #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dslh
force-pushed
the
multiple_allowed_types
branch
from
e6d3b35
to
12f2632
Compare
| @@ -178,12 +178,23 @@ def validates(attrs, validations) | |||
| doc_attrs = { required: validations.keys.include?(:presence) } | |||
|
|
|||
| # special case (type = coerce) | |||
| validations[:coerce] = validations.delete(:type) if validations.key?(:type) | |||
| validations[:coerce] = validations[:type] if validations.key?(:type) | |||
| validations[:coerce] = validations.delete(:types) if validations.key?(:types) | |||
There was a problem hiding this comment.
Maybe do something here when you have both? Should probably be an exception.
|
I think this is really good. I am down to merging this unless you think I should hold? Anyone else wants to comment? |
Adds `types` option for `requires` and `optional` endpoint parameter declarations, allowing for parameters that have more than one allowed type. See README.md for usage.
dslh
force-pushed
the
multiple_allowed_types
branch
from
12f2632
to
3195ad2
Compare
|
There's the suggested guard and a quick stab at refactoring params_scope.rb a bit. Bundling some of this coercion stuff out could be a good move but I won't get any more time to work on this until at least the weekend. I can either do a supplemental PR or keep working on this one when I get the chance. |
|
I will merge this and we can iterate on top. |
dblock
added a commit
that referenced
this pull request
Oct 21, 2015
Allow parameters with more than one type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #693.
Adds
typesoption forrequiresandoptionalendpoint parameterdeclarations, allowing for parameters that have more than one allowed
type. See README.md for usage.
I have been thinking about the best way to expose some of the more
interesting possibilities for arbitrary type validation that are hidden in Grape,
but in the end this is the only use case I have seen that makes sense to me.