Fix multiple version definitions for path versioning #1414
Conversation
Issue ruby-grape#1400 * New spec for this case * Update CHANGELOG
| @@ -28,6 +28,7 @@ module ClassMethods | |||
| # | |||
| def version(*args, &block) | |||
| if args.any? | |||
| args.flatten! | |||
There was a problem hiding this comment.
The problem was hidden here.
When the version is defined as an array:
version ['v1', 'v2']
then args is presented as an array inside of an array: [["v1", "v2"]], so flatten! here helps to resolve the issue.
There was a problem hiding this comment.
You should not be modifying the parameters passed in, so something like args = args.flatten. However, do investigate why you're getting an array of arrays here, it's possible that there's a better fix upstream.
There was a problem hiding this comment.
Good point. I've extracted version parameter into local variable to describe the intention in a more explicit way => 82e1f21
In this case the upstream is defined by user. I've checked Grape documentation, but I've not found any examples how to properly define several versions for the endpoint. Looks like it is an undocumented feature that was supporting arrays before routing refactoring.
Should it be like that version ['v1', 'v2'] or like that version 'v1', 'v2' or it is not a correct way to define a version at all?
|
This is good, merging. |
It is a fix for issue #1400
I created a new spec for this case and found out why it was not working.