Fix inconsistent validation #1510
Conversation
|
So looks like that code was there intentionally, but without specs. I think it's worth mentioning the behavior change in UPGRADING, please? |
| @@ -1,6 +1,21 @@ | |||
| Upgrading Grape | |||
| =============== | |||
|
|
|||
| ### Upgrading to >= 0.18.0 | |||
There was a problem hiding this comment.
This is incorrect, we have already shipped 0.18.0, so this should be 0.19.0.
There was a problem hiding this comment.
Maybe 0.18.1, I am not sure whether this is major/minor release worthy.
|
If you really want to be nice, squash your commits after you've fixed the version in UPGRADING. I'll merge. |
Add spec for multiple params per requires fix validation inconsistency update changelog update UPGRADING.md
dgasper
force-pushed
the
fix-inconsistent-validation
branch
from
f4f7279 to
afff083
Compare
|
|
||
| #### Changed endpoint params validation | ||
|
|
||
| Grape now returns validation errors for all params when multiple params are passed to a requires. |
There was a problem hiding this comment.
I would add "correctly" otherwise it seems like this is some other kind of behavior change.
|
Sorry just seeing this. Can you please rebase? I'll merge. Appreciate it. |
|
I'm being lazy. Merged via 813925e. |
|
Oh, sorry. Force push doesn't result in a notification. Glad I could contribute. Thanks! |
|
Thanks for your excellent work @dgasper! |
Fixes #1508