-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spec warnings #1583
base: master
Are you sure you want to change the base?
Fix spec warnings #1583
Conversation
C: Convert if nested inside else to elsif.
Interesting. This feels like a workaround rather than a fix. Why wouldn't something like |
Hi @dblock the warnings occur because I did not look into implementation details, my objective was to clear three warnings that were showing in my projects specs, but since I'm here might as well fix them all 😄 Having warnings not suppressed has saved me from some bugs in the past, but it comes with the caveat of having to fix them if we want a sane output when running tests 😛 Would you like me to change something on the PR? |
Yes, lets have this discussion in hashie/hashie#416 first? Same problem but fewer changes. |
Thanks for your contribution. |
I want to revive this. I think a fix that says |
Hi all,
When running specs with warnings on, grape outputs a lot of warnings.
This PR attempts to fix all of them.
With regards to the warnings:
warning: instance variable @disable_warnings not initialized
, by thehashie
gem, I have opened a PR there to fix those: hashie/hashie#416