Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom validator keeping ref to instance variable #1593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

loicginoux
Copy link

This is a failing test that demonstrate a possible bug. This is a failing test in response to this issue #1592.

I have tested both from code at version 0.16.2 and master with similar error.

Not sure if the issue is in custom validator or in the helper. I hope someone knowing better the source code can help on this.
Thanks

@grape-bot
Copy link

grape-bot commented Mar 11, 2017

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1593](https://github.com/ruby-grape/grape/pull/1593): Custom validator keeping ref to instance variable - [@loicginoux](https://github.com/loicginoux).

Generated by 🚫 danger

@dnesteryuk
Copy link
Member

@dblock This one might be closed, the related issue was fixed.

@dblock
Copy link
Member

dblock commented Jan 3, 2020

@loicginoux Want to rebase and retest? Close or update if the test case is useful and I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants