Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1642 Added spec for optional array param #1678

Closed
wants to merge 1 commit into from

Conversation

hwaterke
Copy link

This is related to issue #1642.

When a param of type array is declared as optional, if it is not provided it is converted by declared() to a hash instead of an empty array.

@grape-bot
Copy link

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1678](https://github.com/ruby-grape/grape/pull/1678): #1642 added spec for optional array param - [@hwaterke](https://github.com/hwaterke).

Generated by 🚫 danger

@dblock
Copy link
Member

dblock commented Nov 22, 2017

Closing via #1710

@dblock dblock closed this Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants