[Bug] Fix validations nested under a given
#1691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnubel
force-pushed
the
fix/multiple-param-and-default-validators-with-given
branch
from
e48a8e4
to
b631c02
Compare
|
This needs a |
Multi-param and default validators, all of which implemented their own `validate!` method, were not respecting the `given` dependency as expected. This change copies the check into all those validators. The bug was likely introduced by ruby-grape#1625, which required that the dependency check be moved out of the scope itself and into the validators. Rolling back that change would require fundamentally re-architecting how array parameters are validated (possibly with a new kind of scope).
rnubel
force-pushed
the
fix/multiple-param-and-default-validators-with-given
branch
from
b631c02
to
fe56f15
Compare
|
Bump @rnubel ? |
rnubel
deleted the
fix/multiple-param-and-default-validators-with-given
branch
|
Great. Double check please that there's a spec for this exact scenario and PR that if not. Appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1681.
Multi-param and default validators, all of which implemented their own
validate!method, were not respecting thegivendependency as expected. This change copies the check into all those validators.The bug was likely introduced by #1625, which required that the dependency check be moved out of the scope itself and into the validators. Rolling back that change would require fundamentally re-architecting how array parameters are validated (possibly with a new kind of scope?).