Support nested dependent parameters #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`given` will check whether attribute is declared in its scope.
If not, it raises an error.
```ruby
optional :a
given a: ->(val) { val == 'a' } do
optional :b
given b: ->(val) { val == 'b' } do
requires :c
end
end
```
In the example, `optional :a` creates a scope. `given a: ...` creates
another scope, which parent scope is the one created by `optional :a`,
and attributes `:b` declared in `optional :b` is pushed to parent scope.
The bug here is `given b: ...` cannot find `:b` in its scope. Since the
attribute `:b` is pushed to its parent scope. So, fix the code to
check attribute in its parent scope if it has parent scope.
darren987469
force-pushed
the
fix_issue_1800
branch
from
1365731
to
0b726dd
Compare
|
🚀 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1800. Continue of #1804.
givenwill check whether attribute is declared in its scope.If not, it raises an error.
In the example,
optional :acreates a scope.given a: ...createsanother scope, which parent scope is the one created by
optional :a,and attributes
:bdeclared inoptional :bis pushed to parent scope.The bug here is
given b: ...cannot find:bin its scope. Since theattribute
:bis pushed to its parent scope. So, fix the code tocheck attribute in its parent scope if it has parent scope.