Addresses memory issues related to new multi-instance approach #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Dec 6, 2018
|
Fxed |
|
Did you run the test in #1835? Want to post numbers? |
nijikon
reviewed
Dec 6, 2018
| @@ -6,7 +6,7 @@ module Grape | |||
| # should subclass this class in order to build an API. | |||
| class API | |||
| # Class methods that we want to call on the API rather than on the API object | |||
| NON_OVERRIDABLE = Class.new.methods.freeze | |||
| NON_OVERRIDABLE = Class.new.methods.freeze + %i[call call!] | |||
There was a problem hiding this comment.
I think that this should be (Class.new.methods + %i[call call!]).freeze
There was a problem hiding this comment.
myxoh
added a commit
to BookingBug/grape
that referenced
this pull request
Dec 10, 2018
basjanssen
pushed a commit
to basjanssen/grape
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the new multi-instance approach, class calls to the API are being intercepted, and stored so that they can be call as part of the setup to all instances.
However, when you are running the API in Rack, the method
callis not part of the configuration, but an action. We do NOT want to store every time the methodcallwas called for security and memory management issues:Addresses: #1835