do not collect params in route settings #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnesteryuk
force-pushed
the
chore/remove-needless-route-settings
branch
2 times, most recently
from
45497c4 to
dfe6e3c
Compare
|
maybe some external gem uses this interface(like |
dblock
requested changes
Jan 5, 2022
| @@ -1,5 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) | |||
There was a problem hiding this comment.
unfortunately, yes. I took it from https://github.com/ruby-grape/grape/blob/master/benchmark/compile_many_routes.rb
|
@dm1try we use |
dm1try
approved these changes
Jan 5, 2022
dnesteryuk
force-pushed
the
chore/remove-needless-route-settings
branch
from
dfe6e3c to
d52e1fc
Compare
dblock
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating another issue I discovered that params were documented twice then merged there.
Params are stored in
namespace_stackablethere is no reason to keep them inroute_setting(:description)too.I checked this change against our app, it still works 😉