fix evaluate given in array

CHANGELOG.md

@@ -28,6 +28,7 @@
 * [#2256](https://github.com/ruby-grape/grape/pull/2256): Raise `Grape::Exceptions::MultipartPartLimitError` from Rack when too many files are uploaded - [@bschmeck](https://github.com/bschmeck).
 * [#2266](https://github.com/ruby-grape/grape/pull/2266): Fix code coverage - [@duffn](https://github.com/duffn).
 * [#2284](https://github.com/ruby-grape/grape/pull/2284): Fix an unexpected backtick - [@zysend](https://github.com/zysend).
+* [#2287](https://github.com/ruby-grape/grape/pull/2287): Fix evaluate given in array - [@zysend](https://github.com/zysend).
 * Your contribution here.
 
 ### 1.6.2 (2021/12/30)

lib/grape/dsl/inside_route.rb

@@ -48,7 +48,7 @@ def declared_array(passed_params, options, declared_params, params_nested_path)
 
  def declared_hash(passed_params, options, declared_params, params_nested_path)
  declared_params.each_with_object(passed_params.class.new) do |declared_param_attr, memo|
- next if options[:evaluate_given] && !declared_param_attr.meets_dependency?(options[:request_params])
+ next if options[:evaluate_given] && !declared_param_attr.scope.meets_dependency?(passed_params, options[:request_params])
 
  declared_hash_attr(passed_params, options, declared_param_attr.key, params_nested_path, memo)
  end

lib/grape/validations/params_scope.rb

@@ -21,12 +21,6 @@ def initialize(key, scope)
  @scope = scope
  end
 
- def meets_dependency?(request_params)
- return true if scope.nil?
-
- scope.meets_dependency?(scope.params(request_params), request_params)
- end
-
  # @return Array[Symbol, Hash[Symbol => Array]] declared_params with symbol instead of Attr
  def self.attrs_keys(declared_params)
  declared_params.map do |declared_param_attr|

spec/grape/validations/params_scope_spec.rb

@@ -690,6 +690,34 @@ def initialize(value)
  end
  end
 
+ context 'lateral parameter within an array param' do
+ before do
+ [true, false].each do |evaluate_given|
+ subject.params do
+ optional :array, type: Array do
+ optional :a
+ given a: ->(a) { a == 'a' } do
+ optional :b
+ end
+ end
+ end
+ subject.get("/evaluate_given_#{evaluate_given}") do
+ declared(params, evaluate_given: evaluate_given).to_json
+ end
+ end
+ end
+
+ it 'evaluate_given_false' do
+ get '/evaluate_given_false', array: [{ a: 'c', b: 'b' }, { a: 'a', b: 'b' }]
+ expect(JSON.parse(last_response.body)).to eq('array' => [{ 'a' => 'c', 'b' => 'b' }, { 'a' => 'a', 'b' => 'b' }])
+ end
+
+ it 'evaluate_given_true' do
+ get '/evaluate_given_true', array: [{ a: 'c', b: 'b' }, { a: 'a', b: 'b' }]
+ expect(JSON.parse(last_response.body)).to eq('array' => [{ 'a' => 'c' }, { 'a' => 'a', 'b' => 'b' }])
+ end
+ end
+
  context 'nested parameter' do
  before do
  [true, false].each do |evaluate_given|