Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix, do not use kwargs for empty args #2299

Merged
merged 1 commit into from
Dec 30, 2022
Merged

fix, do not use kwargs for empty args #2299

merged 1 commit into from
Dec 30, 2022

Conversation

dm1try
Copy link
Member

@dm1try dm1try commented Dec 29, 2022

for backward compatibility with the previous implemention
where options param behaves as an empty hash by default

see #2295

@dm1try dm1try mentioned this pull request Dec 29, 2022
Closed
@dm1try
fix, do not use kwargs for empty args
b51665d 
for backward compatibility with the previous implemention
where options param behaves as an empty hash by default
see #2295
@dm1try dm1try force-pushed the fix_shared_params_empty_args branch from 1c6eafd to b51665d Compare December 29, 2022 22:08
@dblock dblock merged commit d1b8e86 into master Dec 30, 2022
@dblock
Copy link
Member

dblock commented Dec 30, 2022

Thanks for the fix @dm1try !

@dblock dblock deleted the fix_shared_params_empty_args branch December 31, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dm1try @dblock