Remove Rack::Auth::Digest #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's document this in UPGRADING, please? I think we can start following major version semver from here, and bump the version of Grape to 2.0 in this PR since this is a visibly breaking change? Could you please do it? |
…/grape into remove-Rack-Auth-Digest
|
Sure, I updated README, CHANGELOG and also UPGRADING. Let me know if it's not enough or if I miss something. |
dblock
requested changes
Oct 25, 2023
|
README#stable-release still needs a bump to 2.0, please? |
Oops, I updated it by 4905cc6. |
dblock
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Rack::Auth::Digest.As far as I understand, #2294 reaches a conclusion that removing
Rack::Auth::Digestis the way to go.(It's my first time to make a PR to this repository. So please let me know if I miss something)