fix(#2350): Update recognize_paths taking into account the route_param type
#2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcagarcia
force-pushed
the
issue-2350
branch
from
d4e0102
to
c35ac86
Compare
…aking into account the route_param type
jcagarcia
force-pushed
the
issue-2350
branch
from
c35ac86
to
c8adb79
Compare
dblock
approved these changes
Nov 24, 2023
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR tries to fix the issue described in #2350
With this changes, the
recognize_pathsmethod takes into account theroute_paramtype (if specified) for determine if a path matches with the performed request.This change has an important implication that has been added to the
UPGRADEDfile:Before this change, if a request was performed to an endpoint that has specified the type of the
route_param, the path was recognized. If finally the provided parameter in the request didn't match with the specifiedroute_paramtype. A400 Bad Requestresponse was returning, indicating that the provided param in the path was not valid. With these changes, as the path is directly not recognized if it does not accomplish with the specifiedroute_paramtype, we are returning a404 Not Foundresponse.Is that consider a breaking change? It is a bug fix?
Any comment, suggestion and discussion is totally welcome 👍