Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Hash with Rack::Header/Rack::Utils::HeaderHash for Grape Headers #2425

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Replace Hash with Rack::Header/Rack::Utils::HeaderHash for Grape Headers #2425

merged 1 commit into from
Apr 15, 2024

Conversation

dhruvCW
Copy link
Contributor

@dhruvCW dhruvCW commented Apr 6, 2024

This closes #2396

@dhruvCW dhruvCW changed the title replace Hash with Rack::Header/Rack::Utils::HeaderHash for Grape Headers Replace Hash with Rack::Header/Rack::Utils::HeaderHash for Grape Headers Apr 6, 2024
@ericproulx
Copy link
Contributor

ericproulx commented Apr 6, 2024 •
edited
Loading

I think there's this one left here.
Thanks for doing this :)

@dhruvCW
Copy link
Contributor Author

dhruvCW commented Apr 6, 2024

I think there's this one left here. Thanks for doing this :)

ah thanks 😅 missed that, should be fixed now 👍

dblock
dblock requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some asks below.

CHANGELOG.md Outdated Show resolved Hide resolved
lib/grape/dsl/headers.rb Outdated Show resolved Hide resolved
lib/grape/endpoint.rb Outdated Show resolved Hide resolved
lib/grape/util/header.rb Outdated Show resolved Hide resolved
@dhruvCW dhruvCW requested a review from dblock April 14, 2024 09:41
@dblock
Copy link
Member

dblock commented Apr 15, 2024

Great, merging. I don't think we need anything for UPGRADING.md, but if you disagree, please PR.

@dblock dblock merged commit 79d5798 into ruby-grape:master Apr 15, 2024
38 checks passed
@dhruvCW dhruvCW deleted the header_hash branch April 15, 2024 01:51
@ericproulx ericproulx mentioned this pull request May 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Rack's HeadersHash instead of {}
3 participants
@dhruvCW @ericproulx @dblock