Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated except and proc in values validator #2501

Merged

Conversation

ericproulx
Copy link
Contributor

This PR removes the option proc and except in the values validator. It's been deprecated since version 1.0.0

@ericproulx ericproulx changed the title Remove values_validaton except and proc deprecation Remove deprecated except and proc in values validator Sep 26, 2024
@grape-bot
Copy link

grape-bot commented Sep 26, 2024

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@ericproulx ericproulx requested a review from dblock September 26, 2024 16:10
@ericproulx ericproulx marked this pull request as ready for review September 26, 2024 16:12
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPGRADING nits, thanks!

There's some inconsistent capitalization in other lines of UPGRADING, appreciate if you could make those the same too :)

UPGRADING.md Outdated
#### Remove deprecated methods

Deprecated `file` method has been removed. Use `send_file` or `stream`.
#### Remove deprecated methods and options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Remove deprecated methods and options
#### Remove Deprecated Methods and Options

UPGRADING.md Outdated

- Deprecated `file` method has been removed. Use `send_file` or `stream`.
See [#2500](https://github.com/ruby-grape/grape/pull/2500)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [#2500](https://github.com/ruby-grape/grape/pull/2500)
See [#2500](https://github.com/ruby-grape/grape/pull/2500) for more information.

UPGRADING.md Outdated
See [#2500](https://github.com/ruby-grape/grape/pull/2500)

- `except` and `proc` options have been removed from the `values` validator. Use `except validator` or assign `proc` directly to `values`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `except` and `proc` options have been removed from the `values` validator. Use `except validator` or assign `proc` directly to `values`.
- The `except` and `proc` options have been removed from the `values` validator. Use `except_values` validator or assign `proc` directly to `values`.

UPGRADING.md Outdated
See [#2500](https://github.com/ruby-grape/grape/pull/2500)

- `except` and `proc` options have been removed from the `values` validator. Use `except validator` or assign `proc` directly to `values`.
See [#2501](https://github.com/ruby-grape/grape/pull/2501)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [#2501](https://github.com/ruby-grape/grape/pull/2501)
See [#2501](https://github.com/ruby-grape/grape/pull/2501) for more information.

@ericproulx ericproulx requested a review from dblock September 27, 2024 15:45
UPGRADING.md Outdated Show resolved Hide resolved
@ericproulx ericproulx requested a review from dblock September 27, 2024 17:23
@dblock dblock merged commit 7f0595c into ruby-grape:master Sep 27, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants