Update validator registration mechanism #2508
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces validator registration mechanism. Instead of relying on
self.inherited
, it registers validators by usingconst_get
based on short name. Its does the same thing as the coercers.Drawbacks
Grape::Validations::Validators
modules and class's name must finish byValidator
.In our README, the AlphaNumeric example would need to be in declared like this:
Benefits
lib/grape/validations/validators/custom_validator.rb