Streaming requests broken after 0.2.4. #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have much experience with this kind of things. It would be great to get a spec that reproduces this, happy to help fix. |
|
This looks good. Can you please update CHANGELOG as well? An API-level integration test that makes a full request would be nice, too. |
|
@dblock Can this be merged now? |
|
Looks good, thanks. Merging. |
dblock
added a commit
that referenced
this pull request
Apr 14, 2013
Streaming requests broken after 0.2.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently upgraded from 0.2.4 to 0.4.1. Our client is sending a "Transfer-Encoding: chunked" header with a streamed request and the formatter middleware is failing to read the body input as json. This appears to be because content-length is nil since its a streaming request and the read_body_input method now depends on it being defined and greater than 0.