Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jsonapi content type #475

Closed
wants to merge 3 commits into from
Closed

add jsonapi content type #475

wants to merge 3 commits into from

Conversation

bcm
Copy link
Contributor

@bcm bcm commented Sep 21, 2013

adds support for the "JSON API" media type registered at http://jsonapi.org/.

@dblock
Copy link
Member

dblock commented Sep 21, 2013

Please also update CHANGELOG, thx.

@bcm
Copy link
Contributor Author

bcm commented Sep 21, 2013

updated

@dblock
Copy link
Member

dblock commented Sep 25, 2013

I should have said it earlier, but this needs some kind of test that exercises the format. Even something so trivial.

these tests are based on the existing json formatter and exception tests.
I didn't see any existing parser tests.
@bcm
Copy link
Contributor Author

bcm commented Sep 25, 2013

updated with tests

@dblock
Copy link
Member

dblock commented Sep 25, 2013

Committed as b0123a4

@dblock dblock closed this Sep 25, 2013
@bcm bcm deleted the jsonapi branch November 21, 2013 17:14
@miguelsan
Copy link

This should be documented in the README.
Besides, the JSONAPI standard was recently updated, the current formatter is not standard conform.

@dblock
Copy link
Member

dblock commented Jul 7, 2014

@miguelsan You're right, we list formatters. Would appreciate a PR please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants