Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rescue_from tests now use different exception names #548

Merged
merged 4 commits into from
Jan 3, 2014
Merged

rescue_from tests now use different exception names #548

merged 4 commits into from
Jan 3, 2014

Conversation

xevix
Copy link
Contributor

@xevix xevix commented Jan 3, 2014

To avoid clashing exception names and for clarity:

  • Use context/before blocks for defining exception classes
  • For the rescue_subclasses tests, use the same class names as in the README for consistency
  • Remove unnecessary test showing that 2 rescue_from calls don't interfere with each other

@xevix xevix mentioned this pull request Jan 3, 2014
Merged
dblock added a commit that referenced this pull request Jan 3, 2014
@dblock
Merge pull request #548 from xevix/rescue_from_tests_use_different_ex…
e53042d 
…ception_names

rescue_from tests now use different exception names
@dblock dblock merged commit e53042d into ruby-grape:master Jan 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xevix @dblock