do not use any Entity constant that is available in namespace, as it can... #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -332,7 +332,9 @@ def present(*args) | |||
| entity_class ||= (settings[:representations] || {})[potential] | |||
| end | |||
|
|
|||
| entity_class ||= object_instance.class.const_get(:Entity) if object_instance.class.const_defined?(:Entity) | |||
| if object_instance.class.const_defined?(:Entity) | |||
| entity_class ||= object_instance.class.const_get(:Entity) if object_instance.class.const_get(:Entity).respond_to?(:represent) | |||
There was a problem hiding this comment.
You probably want to move the right-hand-side of the if up as well.
if object_instance.class.const_defined?(:Entity) && object_instance.class.const_get(:Entity).respond_to?(:represent)
...Right?
There was a problem hiding this comment.
yes wanted, but it appeared to become very long line
|
Please update the CHANGELOG and check the Rubocop violation in https://travis-ci.org/intridea/grape/jobs/21130443. |
…can be not a presenter one
|
Updated |
dblock
added a commit
that referenced
this pull request
Mar 20, 2014
do not use any Entity constant that is available in namespace, as it can...
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced problem with grape when I had an active record model in my project with name Entity. This model is not connected with grape at all, but grape looks for any constant with name Entity, and tries to use it to present values that does not have explicit presenter, like simple strings. So it is usual case to see errors like:
by this PL I suggest to make at least check that an object has such method before calling it. Ideally I suppose would be ability to config the name of an auto-detect entity class or be able to disable it