Attemp to fix #866 and #867 #868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dblock Sorry, this is a incorrect fix. I'll find another way to fix this and rebase the commit. |
| @@ -99,7 +99,6 @@ def reset_routes! | |||
| def mount_in(route_set) | |||
| if endpoints | |||
| endpoints.each do |e| | |||
| e.inheritable_setting.inherit_from inheritable_setting | |||
There was a problem hiding this comment.
@dblock Delete this line fix the issue, this line was introduced in this commit f8596829.
@dspaeth-faber Is this line necessary?
There was a problem hiding this comment.
The intention is to inherit everything when an API is mounted, but it looks like it has the exact opposite effect?
If we mount a Grape::API app which using version and namespaces to another Grape::API app, the version setting will lost.
|
We do need to figure out what is happening right now by inheriting everything from parent's inheritable settings and why it is causing the issue at hand. I am going to say that if all specs + new ones pass, we can take the fix. Can you please update CHANGELOG for this? |
|
@dblock updated. |
|
Merged via 0c0e85f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we mount a Grape::API app which using version and namespaces to another
Grape::API app, the version setting will lost.