Remove route_info from params (Close #789) #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely needs a CHANGELOG entry and possibly an UPGRADING note. |
|
Updated |
| @@ -5,6 +5,8 @@ Upgrading Grape | |||
|
|
|||
| Grape now supports, but doesn't require Rack 1.6.0. If you encounter an issue with parsing requests larger than 128KB, explictly require Rack 1.6.0 in your Gemfile. | |||
|
|
|||
| Key route_info is excluded from params. See [#879](https://github.com/intridea/grape/pull/879) for more information. | |||
There was a problem hiding this comment.
This looks confusing, the description is above a Gemfile example that relates to the note above. Make it two sections, something like:
### Added Rack 1.6.0 Support
...
### Removed route_info
Also please properly backquote things like params.
|
@dblock I was too rush, right. Changed |
dblock
added a commit
that referenced
this pull request
Jan 8, 2015
Remove route_info from params (Close #789)
|
Merged, thanks. |
|
Is there any other way how to get this information? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.