Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #881 #899

Merged
merged 1 commit into from
Jan 17, 2015
Merged

Fix for #881 #899

merged 1 commit into from
Jan 17, 2015

Conversation

ajvondrak
Copy link
Contributor

I added some regression tests and avoid to_a-ing the Range at all. What do you think?

@dblock
Copy link
Member

dblock commented Jan 17, 2015

This is good. You have to look at CI failures on those other platforms (we do support them :)) and squash the commits please.

@ajvondrak
Copy link
Contributor Author

Woops, hadn't noticed the build failing. :) Ruby 1.9.3 doesn't have a Range#size method, as it turns out.

Anyway, fixed (assuming Travis says so) & squashed.

@dblock
Copy link
Member

dblock commented Jan 17, 2015

Thanks, merging.

dblock added a commit that referenced this pull request Jan 17, 2015
@dblock
Merge pull request #899 from ajvondrak/881
6379215 
Fix for #881
@dblock dblock merged commit 6379215 into ruby-grape:master Jan 17, 2015
@ajvondrak ajvondrak mentioned this pull request Jan 22, 2015
Closed
@u2
Copy link
Contributor

u2 commented Jan 22, 2015

👍

@u2 u2 mentioned this pull request Jan 30, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajvondrak @dblock @u2