add support for scoped callbcaks within a version block #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the perfect fix. Add CHANGELOG, update README and UPGRADING (explicitly call this a regression and that the behavior is fixed in the next version). |
|
I've documented everything as you mentioned. It would be great if you could merge this and release a new version of this gem if possible. Thanks once again! |
| @@ -5,6 +5,7 @@ Next Release | |||
| * [#559](https://github.com/intridea/grape/issues/559): Support Rack 1.6.0 to parse requests larger than 128KB - [@myitcv](https://github.com/myitcv). | |||
| * [#876](https://github.com/intridea/grape/pull/876): declared(params) now returning Hashie::Mash - [@rodzyn](https://github.com/rodzyn). | |||
| * [#879](https://github.com/intridea/grape/pull/879): route_info is not included in params Hash anymore - [@rodzyn](https://github.com/rodzyn). | |||
| * [#901](https://github.com/intridea/grape/pull/901): callbacks defined in a version block are only called for the routes defined in that block - [@kushkella](https://github.com/kushkella). | |||
There was a problem hiding this comment.
Start with Fix: callbacks ... and fix the extra space after the -, please.
|
Made minor comments. Can you please update with those and squash the commits. Thank you. |
kushkella
force-pushed
the
version-block
branch
from
340dedc
to
fd1f1b8
Compare
update CHANGELOG, README and UPGRADING fix copy
kushkella
force-pushed
the
version-block
branch
from
fd1f1b8
to
86c5bdb
Compare
|
I've made the changes, squashed the commits and rebased on master. Thank you. |
dblock
added a commit
that referenced
this pull request
Jan 18, 2015
add support for scoped callbcaks within a version block
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer #898. I haven't really understood in depth how Grape works internally, but I think this should solve the problem. I would really appreciate if you could give some feedback.
I haven't documented this PR since I'm not sure if this is the correct fix. After I receive some feedback, I'll document this PR. Thanks!