fix weird behaviour for optional groups with default params

[dm1try]

apply defaults for inner params only if parent param is present

fixes #615 (see for more info)

/cc @dblock take a look

[dblock]

Looks good, just needs CHANGELOG.

[dm1try]

@dblock up

[dblock]

I released 0.11.0 today, so this needs to bump into Next Release, sorry for the hassle.

[u2]

      it 'optional array if empty array params' do
        post '/optional_array', { optional_array: [] }.to_json
        expect(last_response.status).to eq(201)
        expect(last_response.body).to eq({ optional_array: [] }.to_json)
      end

if optional array without default value includes optional param with default value, here shoud return { optional_array: [] }.to_json, right?

     Failure/Error: expect(last_response.body).to eq({ optional_array: [] }.to_json)

       expected: "{\"optional_array\":[]}"
            got: "{\"optional_array\":null}"

       (compared using ==)

[dm1try]

Yes, it is right but you forgot to provide application/json content type in your spec.
You cannot send an empty array using http query key/value pairs this is why your spec fails.

So

      it 'optional array if empty array params' do
        header 'Content-Type', 'application/json'
        post '/optional_array', { optional_array: [] }.to_json
        expect(last_response.status).to eq(201)
        expect(last_response.body).to eq({ optional_array: [] }.to_json)
      end

should work

[u2]

Thank you.it works.

        subject.params do
          optional :optional_array, type: Array do
            optional :foo_in_optional_array, default: 'bar'
          end
        end
        subject.post '/optional_array_no_declared_params' do
          { no_declared_array: params[:no_declared_array] }
        end

      it 'optional array if params not declared' do
        post '/optional_array_no_declared_params', { no_declared_array: [{id: 2}] }.to_json
        expect(last_response.status).to eq(201)
        expect(last_response.body).to eq({ no_declared_array: [{id: 2}] }.to_json)
      end

And, I can send an array params which not declared in the params block, right?

     Failure/Error: expect(last_response.body).to eq({ no_declared_array: [{id: 2}] }.to_json)

       expected: "{\"no_declared_array\":[{\"id\":2}]}"
            got: "{\"no_declared_array\":null}"

       (compared using ==)

It passed after I add

header 'Content-Type', 'application/json'

it's weird.

[dm1try]

it's weird.

For me it seems normal. You send the json payload with application/x-www-form-urlencoded content type, it does not make a sense. You should remove .to_json if you use this content type or provide application/json content type as above if you wanna use a json payload.

[u2]

Thank you for your explication. :-)

[dm1try]

@u2 sure) so #937 can be closed I think.

[u2]

Yes.