I18n::Backend::Chain#translations should merge from all backends #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/fnando/i18n-js uses the `#translations` method to dump all translations to a javascript file during asset compilation. The chain backend should deep_merge all these translations in order to dump the appropriate values.
radar
requested changes
Feb 25, 2019
|
The intention behind this change is good. I think it is a sensible approach. It breaks some tests, however. Please look at CI to see what has broken (https://travis-ci.org/ruby-i18n/i18n/jobs/493813293) and work on fixing it. |
|
Hi @radar , Please take another look. |
|
This code looks great to me. Thanks @gburgett! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/fnando/i18n-js uses the
#translationsmethod to dump all translations to a javascript file during asset compilation. The chain backend should deep_merge all these translations in order to dump the appropriate values.My use case:
I've created a backend which pulls translations from my CMS, and hooked that up in a chain backend to first try the CMS and second try the default .yml files. I18n-js was not dumping any of the translations from my yml files to the resulting javascript.