Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with RDoc generation #698

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

davetron5000
Copy link
Contributor

Reading the RDoc and noticed a few things weren't generating correctly.

  • RDoc supports * to bold something, but only at the word level. For more than one word, you have to use <b> tags
  • There was a dangling <tt> unclosed
  • For inline code, the code must be indented or it won't format as code

# end
#
# I18n::Backend::Simple.include(I18n::Backend::Pluralization)
# module I18n::Backend::Pluralization
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize technically one space would suffice, but four seemed better for reading the docs inline so that the indentation is clearly intentional. LMK if it should be done differently.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work how you want it to :)

@radar radar merged commit eacc34f into ruby-i18n:master Aug 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants