Use SecureRandam to generate salt

ruby-ldap · Jan 6, 2015 · b412ca0 · b412ca0
1 parent beac837
commit b412ca0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/net/ldap/password.rb b/lib/net/ldap/password.rb
@@ -27,7 +27,7 @@ def generate(type, str)
       when :sha
          attribute_value = '{SHA}' + Base64.encode64(Digest::SHA1.digest(str)).chomp! 
       when :ssha
-         srand; salt = (rand * 1000).to_i.to_s 
+         srand; salt = SecureRandom.random_bytes(16)
          attribute_value = '{SSHA}' + Base64.encode64(Digest::SHA1.digest(str + salt) + salt).chomp!
       else
          raise Net::LDAP::HashTypeUnsupportedError, "Unsupported password-hash type (#{type})"