Skip to content

Send DN and newPassword with password_modify request #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Send DN and newPassword with password_modify request #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/net/ldap/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,11 +593,11 @@ def password_modify(args)

ext_seq = [Net::LDAP::PasswdModifyOid.to_ber_contextspecific(0)]

unless args[:old_password].nil?
pwd_seq = [args[:old_password].to_ber(0x81)]
pwd_seq << args[:new_password].to_ber(0x82) unless args[:new_password].nil?
ext_seq << pwd_seq.to_ber_sequence.to_ber(0x81)
end
pwd_seq = []
pwd_seq << dn.to_ber(0x80)
pwd_seq << args[:old_password].to_ber(0x81) unless args[:old_password].nil?
pwd_seq << args[:new_password].to_ber(0x82) unless args[:new_password].nil?
ext_seq << pwd_seq.to_ber_sequence.to_ber(0x81)

request = ext_seq.to_ber_appsequence(Net::LDAP::PDU::ExtendedRequest)

Expand Down
15 changes: 14 additions & 1 deletion test/integration/test_password_modify.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
class TestPasswordModifyIntegration < LDAPIntegrationTestCase
def setup
super
@ldap.authenticate 'cn=admin,dc=rubyldap,dc=com', 'passworD1'
@admin_account = {dn: 'cn=admin,dc=rubyldap,dc=com', password: 'passworD1', method: :simple}
@ldap.authenticate @admin_account[:dn], @admin_account[:password]

@dn = 'uid=modify-password-user1,ou=People,dc=rubyldap,dc=com'

Expand Down Expand Up @@ -74,6 +75,18 @@ def test_password_modify_generate_no_old_password
'New password should be valid'
end

def test_password_modify_overwrite_old_password
assert @ldap.password_modify(dn: @dn,
auth: @admin_account,
new_password: 'passworD3')

refute @ldap.bind(username: @dn, password: 'passworD1', method: :simple),
'Old password should no longer be valid'

assert @ldap.bind(username: @dn, password: 'passworD3', method: :simple),
'New password should be valid'
end

def teardown
@ldap.delete dn: @dn
end
Expand Down