Code

enable TLS hostname validation#279

Code

Merged

jch merged 39 commits intoruby-ldap:masterruby-ldap/ruby-net-ldap:masterfrom tmaher:tls-verify-hostnamestmaher/ruby-net-ldap:tls-verify-hostnamesCopy head branch name to clipboardAug 24, 2016

+629-103

Commits

Commits on Aug 23, 2016

• fix iptables blackholing for macOS

  

  Tom Maher

  committed
  84ab4c2

  Copy full SHA for 84ab4c2

• new fixture CA, now with private key

  

  Tom Maher

  committed
  7b2bb02

  Copy full SHA for 7b2bb02

• vagrant fix for macOS v Linux?

  

  Tom Maher

  committed
  2137361

  Copy full SHA for 2137361

• helper should use the new CA

  

  Tom Maher

  committed
  38b6147

  Copy full SHA for 38b6147

• rubocop fix

  

  Tom Maher

  committed
  b42e931

  Copy full SHA for b42e931

• cherry pick from ruby-ldap#259

  

  JPvRiel-SB

  authored and

  Tom Maher

  committed
  22eaf7c

  Copy full SHA for 22eaf7c

• check that the encryption hash is defined before using it

  

  Tom Maher

  committed
  d7b36d1

  Copy full SHA for d7b36d1

• add tests for cert/hostname mismatch

  

  Tom Maher

  committed
  748f1b9

  Copy full SHA for 748f1b9

• stupid portforwarding tricks for local testing

  

  Tom Maher

  committed
  9bab5a5

  Copy full SHA for 9bab5a5

• omit example

  

  Tom Maher

  committed
  381fdf4

  Copy full SHA for 381fdf4

• doc tweak

  

  Tom Maher

  committed
  fd1c823

  Copy full SHA for fd1c823

• too many markdown syntaxes

  

  Tom Maher

  committed
  7593af1

  Copy full SHA for 7593af1

• remove stale reference to gem

  

  Tom Maher

  committed
  052f90d

  Copy full SHA for 052f90d

• extra ldap object for multiple host tests

  

  Tom Maher

  committed
  ca4e390

  Copy full SHA for ca4e390

• add multi-host SSL checks

  

  Tom Maher

  committed
  c6a465f

  Copy full SHA for c6a465f

• include "localhost" as valid cert name

  

  Tom Maher

  committed
  1300bc0

  Copy full SHA for 1300bc0

• tidy up the TLS tests

  

  Tom Maher

  committed
  440ce7f

  Copy full SHA for 440ce7f

• fix up to look like ruby-ldap#259 (diff)

  

  Tom Maher

  committed
  199f429

  Copy full SHA for 199f429

• remove useless test CA

  

  Tom Maher

  committed
  caf1911

  Copy full SHA for caf1911

• only use tcp/9389 with vagrant, use the right exception for bad TLS connections

  

  Tom Maher

  committed
  c801132

  Copy full SHA for c801132

• handle both exceptions

  

  Tom Maher

  committed
  80bab6c

  Copy full SHA for 80bab6c

• single vs multiple hosts throw different exceptions

  

  Tom Maher

  committed
  eeb7a6d

  Copy full SHA for eeb7a6d

• more TLS tests around merging vs not merging the default options

  

  Tom Maher

  committed
  c5f2126

  Copy full SHA for c5f2126

• fix bogus multi-host check

  

  Tom Maher

  committed
  d2ba5e6

  Copy full SHA for d2ba5e6

• remove vagrant port override, because $INTEGRATION_PORT

  

  Tom Maher

  committed
  41881aa

  Copy full SHA for 41881aa

• more no-merge-default-opts tests, done properly

  

  Tom Maher

  committed
  19f9c7d

  Copy full SHA for 19f9c7d

• more docs about vagrant setup

  

  Tom Maher

  committed
  3c18b1e

  Copy full SHA for 3c18b1e

• add script to generate fixture

  

  Tom Maher

  committed
  0f51b56

  Copy full SHA for 0f51b56

• use script-generated fixture CA

  

  Tom Maher

  committed
  02a29ea

  Copy full SHA for 02a29ea

• describe where fixture CA comes from; also indent

  

  Tom Maher

  committed
  7de6335

  Copy full SHA for 7de6335

• linter quoting complaint

  

  Tom Maher

  committed
  a890f03

  Copy full SHA for a890f03

Commits on Aug 24, 2016

• test that no tls_options means we get the system CA bundle

  

  Tom Maher

  committed
  3aebc3d

  Copy full SHA for 3aebc3d

• improve system store tests

  

  Tom Maher

  committed
  4e5a8e7

  Copy full SHA for 4e5a8e7

• use default tls opts for validation

  

  Tom Maher

  committed
  0a8c099

  Copy full SHA for 0a8c099

• properly add the fixture CA to CI system store

  

  Tom Maher

  committed
  8ed4dca

  Copy full SHA for 8ed4dca

• names matter

  

  Tom Maher

  committed
  efd354a

  Copy full SHA for efd354a

• don't need the whole default hash for a verify?

  

  Tom Maher

  committed
  0926274

  Copy full SHA for 0926274

• add docs on how to actually validate an LDAP server cert

  

  Tom Maher

  committed
  72ba381

  Copy full SHA for 72ba381

• whoops, DEFAULT_PARAMS is already a hash

  

  Tom Maher

  committed
  435332d

  Copy full SHA for 435332d