Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net::LDAP#open does not cache bind result #334

Merged
merged 7 commits into from
Nov 18, 2019
Merged

Net::LDAP#open does not cache bind result #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8ba3f95
demonstrates Net::LDAP#open does not expose bind results
vroldanbet Nov 12, 2019
c8bd985
caches bind result
vroldanbet Nov 12, 2019
3455b30
Revert "caches bind result", to see if failing in CI
vroldanbet Nov 15, 2019
ab18e5b
the test environment expects a valid DNS as username
vroldanbet Nov 12, 2019
92be710
Revert "Revert "caches bind result", to see if failing in CI"
vroldanbet Nov 15, 2019
dc99286
bump gem version, assuming semver
vroldanbet Nov 15, 2019
c7d7d15
Merge branch 'master' of https://github.com/ruby-ldap/ruby-net-ldap i…
vroldanbet Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/ldap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ def open
begin
@open_connection = new_connection
payload[:connection] = @open_connection
payload[:bind] = @open_connection.bind(@auth)
payload[:bind] = @result = @open_connection.bind(@auth)
yield self
ensure
@open_connection.close if @open_connection
Expand Down
2 changes: 1 addition & 1 deletion lib/net/ldap/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Net
class LDAP
VERSION = "0.16.1"
VERSION = "0.16.2"
end
end
8 changes: 8 additions & 0 deletions test/integration/test_return_codes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@
# See: section 12.12 http://www.openldap.org/doc/admin24/overlays.html

class TestReturnCodeIntegration < LDAPIntegrationTestCase
def test_open_error
@ldap.authenticate "cn=fake", "creds"
@ldap.open do
result = @ldap.get_operation_result
assert_equal Net::LDAP::ResultCodeInvalidCredentials, result.code
end
end

def test_operations_error
refute @ldap.search(filter: "cn=operationsError", base: "ou=Retcodes,dc=example,dc=org")
assert result = @ldap.get_operation_result
Expand Down