Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor relying_party_key into Warden::WebAuthn::RackHelpers #4

Closed
tcannonfodder opened this issue Jun 24, 2023 · 0 comments · Fixed by #5
Closed

Refactor relying_party_key into Warden::WebAuthn::RackHelpers #4

tcannonfodder opened this issue Jun 24, 2023 · 0 comments · Fixed by #5

Comments

@tcannonfodder
Copy link
Contributor

As part of the discussion for devise-passkeys, it became clear that Warden::WebAuthn::StrategyHelpers was being included in places that extend beyond its intended purpose. (see: ruby-passkeys/devise-passkeys#25 (comment))

A major cause of that was the relying_party_key method, which devise-passkeys was using to add the relying party to the request ENV.

In order to keep the two gems separated cleanly (to reduce conflicts like this), we need to:

  • Break out the relying_party_key into a new Warden::WebAuthn::RackHelpers module
  • Auto-include that module as part of Warden::WebAuthn::StrategyHelpers to achieve the same goal of a centrally located default key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant