Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless method #6

Conversation

Vagab
Copy link
Contributor

@Vagab Vagab commented Jun 24, 2023

@tcannonfodder as I mentioned in #4, I don't think this pr is going to affect anything, just a cleanup really

@tcannonfodder
Copy link
Contributor

Oh my god; you're 100% right 🤦. I thought I'd moved the relying_party_key method entirely over from StrategyHelpers => RackHelpers; but I must have forgotten to stage that in the commit. I'll get this merged in ASAP

@tcannonfodder tcannonfodder self-requested a review June 24, 2023 20:58
@tcannonfodder tcannonfodder force-pushed the remove-relying-party-key-from-strategy-helpers branch from 66d11d8 to c1635e4 Compare June 24, 2023 21:01
@tcannonfodder tcannonfodder merged commit 634b747 into ruby-passkeys:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants