Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent-ruby support #185

Closed
rainerborene opened this issue Feb 28, 2016 · 6 comments
Closed

Concurrent-ruby support #185

rainerborene opened this issue Feb 28, 2016 · 6 comments
Milestone

Comments

@rainerborene
Copy link

any plans to replace celluloid with concurrent-ruby?

@phstc
Copy link
Collaborator

phstc commented Feb 29, 2016

Hi @rainerborene

It seems to be an interesting idea, it was also commented here. Unfortunately I can't work on this at moment, but a pull request would be very appreciated.

@gwincr11
Copy link

gwincr11 commented Jul 7, 2016

I am interested in using this gem, but I just removed the .16 version of celluloid that you require to get rid of a memory leak. It is a known leaky gem https://github.com/ASoftCo/leaky-gem.

Can Shoryuken at least be updated to the non-leaky version?

@phstc
Copy link
Collaborator

phstc commented Jul 7, 2016

TIL: https://github.com/ASoftCo/leaky-gems

@gwincr11 yay! Changed here.

@rainerborene @gwincr11 can you guys help with testing the change above? 🙏

gem 'shoryuken', github: 'phstc/shoryuken', branch: 'feature/185-bump-celluloid-non-leaky-version'

@gwincr11
Copy link

gwincr11 commented Jul 7, 2016

Oh nice, thank you!
I can try to test. I have actually never used this gem before so I have some setup to figure out.

@phstc phstc changed the title celluloid dependency Concurrent-ruby support Sep 2, 2016
@geun
Copy link

geun commented Oct 13, 2016

+1

@phstc
Copy link
Collaborator

phstc commented Dec 21, 2016

Just a heads up... I'm very excited with the changes in #291 so far. I'm thinking on releasing Shoryuken 3.0.0, with that change. It's basically removing Celluloid, in favor of a thread pool and a heartbeat, both from concurrent-ruby. No more actors, and the issues with messages, having to trap died actors etc. Super simple, as it should be.

@phstc phstc added the v3 label Feb 19, 2017
@phstc phstc closed this as completed in 4f2ba80 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants