-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrent-ruby support #185
Comments
It seems to be an interesting idea, it was also commented here. Unfortunately I can't work on this at moment, but a pull request would be very appreciated. |
I am interested in using this gem, but I just removed the .16 version of celluloid that you require to get rid of a memory leak. It is a known leaky gem https://github.com/ASoftCo/leaky-gem. Can Shoryuken at least be updated to the non-leaky version? |
@rainerborene @gwincr11 can you guys help with testing the change above? 🙏 gem 'shoryuken', github: 'phstc/shoryuken', branch: 'feature/185-bump-celluloid-non-leaky-version' |
Oh nice, thank you! |
+1 |
Just a heads up... I'm very excited with the changes in #291 so far. I'm thinking on releasing Shoryuken 3.0.0, with that change. It's basically removing Celluloid, in favor of a thread pool and a heartbeat, both from concurrent-ruby. No more actors, and the issues with messages, having to trap died actors etc. Super simple, as it should be. |
any plans to replace celluloid with concurrent-ruby?
The text was updated successfully, but these errors were encountered: