Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Rdoc for Base64 #7

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Enhanced Rdoc for Base64 #7

merged 2 commits into from
Nov 7, 2023

Conversation

BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Oct 1, 2021

Revises introductory text and method descriptions.

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Oct 1, 2021
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for improving! 🎉

@BurdetteLamar BurdetteLamar marked this pull request as draft October 3, 2021 12:21
@BurdetteLamar BurdetteLamar marked this pull request as ready for review October 4, 2021 21:13
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready!

@BurdetteLamar BurdetteLamar requested a review from mame October 27, 2021 20:43
@BurdetteLamar
Copy link
Member Author

@mame, you are the maintainer here? Can you (or someone) review?

@jcmfernandes
Copy link
Contributor

I just wanted to stop by to say wow. Thank you, @BurdetteLamar. This is a fantastic piece of work 👏.

@BurdetteLamar
Copy link
Member Author

I just wanted to stop by to say wow. Thank you, @BurdetteLamar. This is a fantastic piece of work 👏.

Thanks, @jcmfernandes.

@hsbt hsbt merged commit 155c39a into ruby:master Nov 7, 2023
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 7, 2023
(ruby/base64#7)

* Enhanced Rdoc for Base64

* Enhanced RDoc for Base64

ruby/base64@155c39a949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

4 participants