-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double colon in Hash keys (:sym: "value"
→ sym: "value"
)
#1003
Open
amomchilov
wants to merge
8
commits into
ruby:master
Choose a base branch
from
Shopify:plain-symbol-keys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
changed the title
Double colon in Hash keys (
Double colon in Hash keys (Jul 27, 2023
:sym:
→ sym:
):sym: "value"
→ sym: "value"
)
amomchilov
changed the title
Double colon in Hash keys (
Remove double colon in Hash keys (Jul 27, 2023
:sym: "value"
→ sym: "value"
):sym: "value"
→ sym: "value"
)
Are VS Code's pictures reversed? |
@st0012 Yes they were. Fixed! 😅 |
This was referenced Jul 28, 2023
ono-max
approved these changes
Dec 10, 2023
amomchilov
force-pushed
the
plain-symbol-keys
branch
2 times, most recently
from
January 4, 2024 04:48
46c0421
to
7e3c8f1
Compare
These values are assumed to be 0 if they're missing.
amomchilov
force-pushed
the
plain-symbol-keys
branch
from
November 14, 2024 21:31
7e3c8f1
to
79430da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on the changes in #1001. Only this last commit of this PR is unique to this change.
Description
:
after the key, so the final result looks closer Ruby's Hash syntax, like:{ sym: 1 }
Here's an example for this hash: