Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several warnings when it runs tests #392

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix several warnings when it runs tests #392

merged 1 commit into from
Nov 16, 2021

Conversation

ono-max
Copy link
Member

@ono-max ono-max commented Nov 15, 2021

The following warnings are fixed in this PR.

warning: instance variable @temp_file not initialized
warning: ambiguous first argument; put parentheses or a space even after `/' operator

@ono-max ono-max force-pushed the patch-11 branch 4 times, most recently from 893c002 to 6cd7210 Compare November 15, 2021 08:29
olleolleolle
olleolleolle approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good repairs, reduces the output amount when running tests.

@ko1 ko1 merged commit cdb1e7a into ruby:master Nov 16, 2021
@ono-max ono-max deleted the patch-11 branch November 16, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ono-max @olleolleolle @ko1