Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support completion on DAP #438

Merged
merged 1 commit into from
Dec 16, 2021
Merged

support completion on DAP #438

merged 1 commit into from
Dec 16, 2021

Conversation

ko1
Copy link
Collaborator

@ko1 ko1 commented Dec 16, 2021

using IRB::InputCompletor::retrieve_completion_data.
This method doesn't return type information so maybe we need to
rewrite it.

@ko1
support completion on DAP
4c3f4d2 
using `IRB::InputCompletor::retrieve_completion_data`.
This method doesn't return type information so maybe we need to
rewrite it.
@ko1
Copy link
Collaborator Author

ko1 commented Dec 16, 2021

target.rb.-.ruby-debug.WSL_.Ubuntu-20.04.-.Visual.Studio.Code.2021-12-16.14-45-15.mp4

st0012
st0012 reviewed Dec 16, 2021
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 I'll use a similar approach to implement the REPL version.

@ko1 ko1 merged commit e73542f into master Dec 16, 2021
@ko1 ko1 deleted the dap_completion branch December 16, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ko1 @st0012