Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckBreakpoint should only stop at the first condition fulfillment line #616

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Apr 6, 2022

As described in #406

When a condition is fulfilled (e.g. a >= 1), it usually remains true for at least a while. However, under the current implementation, it'll stops at every single line after the condition becomes true, which is annoying.

So this PR introduces an extra state to make sure the BP doesn't stop repeatedly after the condition is fulfilled.

Closes #406

When a condition is fulfilled (e.g. a >= 1), it usually remains true for
at least a while. However, under the current implementation, it'll stops
at every single line after the condition becomes true, which is
annoying.

So this PR introduces an extra state to make sure the BP doesn't stop
repeatedly after the condition is fulfilled.
@ko1 ko1 merged commit 33d9c25 into ruby:master Apr 17, 2022
@st0012 st0012 deleted the fix-#406 branch April 17, 2022 16:02
@ko1
Copy link
Collaborator

ko1 commented Apr 17, 2022

I use private def ... to make it clear which methods are private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Stop at CheckBreakpoint only for once
2 participants