introduce CONFIG.skip_all
#665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CONFIG.skip_all` is called to ignore cleanup code. fix #552
st0012
reviewed
Jun 30, 2022
| @@ -18,7 +18,7 @@ def self.setup debug_port | |||
| end | |||
|
|
|||
| at_exit do | |||
| CONFIG[:skip_path] = [//] # skip all | |||
| CONFIG.skip_all | |||
There was a problem hiding this comment.
It's not really a user configuration but a debugger's internal controlling state. So I think DEBUGGER__.skip? is a better place for this method.
There was a problem hiding this comment.
Sorry what is DEBUGGER__.skip? and how to use it for here?
There was a problem hiding this comment.
I meant instead of defining on CONFIG, it can be defined on DEBUGGER__. Because it actually has nothing to do with the configuration.
There was a problem hiding this comment.
I see. It seems better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONFIG.skip_allis called to ignore cleanup code.fix #552